Skip to content

Support referenced libraries#2

Merged
DavidWLoupe merged 8 commits into
mainfrom
feature/support-referenced-libraries
Jul 25, 2024
Merged

Support referenced libraries#2
DavidWLoupe merged 8 commits into
mainfrom
feature/support-referenced-libraries

Conversation

@DavidWLoupe
Copy link
Copy Markdown
Contributor

@DavidWLoupe DavidWLoupe commented Nov 29, 2023

What

Adds functions and tweaks behavior to allow for referenced libraries to be used

Why

Primarily, to support development associated with LPM PR 5, which allows the libraries to be added that reference a folder elsewhere

@DavidWLoupe DavidWLoupe marked this pull request as ready for review December 15, 2023 17:33
Comment thread ASTools.py Outdated
Comment on lines +1068 to +1070
# Note: From empirical testing in AS, the path to a referenced library must be
# relative, if the source is somewhere within the folder where the .apj lives
# absolute, if the source is somewhere outside the folder where the .apj lives
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this, because our repo structure with example and src directories next to each other allows us to specify relative paths to source objects from within .pkg files in the AS project (even though src folder is outside the folder where the .apj lives). Can you elaborate on this? One example of such a reference that works in the axislib repo: <Object Type="Library" Language="ANSIC" Reference="true">..\..\src\ACP10Ar\AxisLib\ANSIC.lby</Object>

Copy link
Copy Markdown
Contributor Author

@DavidWLoupe DavidWLoupe Jan 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are correct that my statements are erroneous. After some more testing, I looks like the more accurate thing to say is along the lines of "AS doesn't allow absolute paths to reference packages that exist within the Logical folder". I think that's it. I also learned a little more about the allowable syntax of AS paths.

Changes are forthcoming

@sclaiborne
Copy link
Copy Markdown
Member

I support this change. Let me know if I can help in any way

@sclaiborne sclaiborne changed the title Feature/support referenced libraries Support referenced libraries May 1, 2024
@DavidWLoupe
Copy link
Copy Markdown
Contributor Author

DavidWLoupe commented Jul 24, 2024

I am going to merge this tomorrow (7/25), unless objections occur

@DavidWLoupe DavidWLoupe merged commit a3cc543 into main Jul 25, 2024
@DavidWLoupe DavidWLoupe deleted the feature/support-referenced-libraries branch July 25, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants